[SDK · Escrow lifecycle] Implement releaseFunds() — payment operation…#105
Open
midenotch wants to merge 3 commits intoamina69:developfrom
Open
[SDK · Escrow lifecycle] Implement releaseFunds() — payment operation…#105midenotch wants to merge 3 commits intoamina69:developfrom
midenotch wants to merge 3 commits intoamina69:developfrom
Conversation
|
@midenotch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, Close: #105 |
Owner
|
@midenotch pipiline failed,, please check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #78
Implemented releaseFunds() in [src/escrow/index.ts] and re-exported it from [src/index.ts]
It now:
converts the balance to stroops and uses BigInt arithmetic for percentage math
builds one Payment operation per distribution entry
preserves exact 7-decimal formatting
distributes any leftover stroops by remainder so the split always sums back to the original balance
I also added unit coverage in [tests/unit/escrow/index.test.ts]
for:
500 XLM with 60/40 => 300.0000000 and 200.0000000
100% to a single recipient
a three-way split that sums exactly to the starting balance
Verification: npm test -- --runInBand passed with 81/81 tests green.