Skip to content

Assemble full release#106

Open
midenotch wants to merge 4 commits intoamina69:developfrom
midenotch:assemble-full-release
Open

Assemble full release#106
midenotch wants to merge 4 commits intoamina69:developfrom
midenotch:assemble-full-release

Conversation

@midenotch
Copy link
Copy Markdown

@midenotch midenotch commented Mar 27, 2026

Closes #80


Close: #80

Implemented releaseFunds() in [src/escrow/index.ts] and re-exported it from [src/index.ts]

It now:

converts the balance to stroops and uses BigInt arithmetic for percentage math
builds one Payment operation per distribution entry
preserves exact 7-decimal formatting
distributes any leftover stroops by remainder so the split always sums back to the original balance
I also added unit coverage in [tests/unit/escrow/index.test.ts]
for:

500 XLM with 60/40 => 300.0000000 and 200.0000000
100% to a single recipient
a three-way split that sums exactly to the starting balance
Verification: npm test -- --runInBand passed with 81/81 tests green.

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 27, 2026

@midenotch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@amina69
Copy link
Copy Markdown
Owner

amina69 commented Mar 28, 2026

@midenotch , test failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants