fix: implement buildSetOptionsOp helper for transaction builders#143
Merged
amina69 merged 2 commits intoamina69:developfrom Mar 30, 2026
Conversation
|
@Yusufolosun Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Good day @amina69 |
amina69
approved these changes
Mar 30, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116
Summary
Adds a dedicated
buildSetOptionsOphelper for transaction builders, covering signer updates, threshold updates, and master weight updates.Root Cause
The transaction builder surface lacked a
setOptionshelper, leaving signer/threshold configuration with no reusable builder function and no focused unit coverage.Fix
Added
buildSetOptionsOpinbuilder.tswith:0removes)masterWeightupdates, including mixed inputExported via
index.ts.Testing
Unit tests added in
index.test.tscovering:Add signer
Remove signer
Threshold updates
Mixed operations
Invalid signer key validation
✅
lintpasses✅
type-checkpasses✅ Unit coverage passes
✅
buildpassesCI
Local checks match required CI stages defined in
sdk-ci.yml: lint, type-check, unit tests with coverage, and build.