Closed
Conversation
…alculation - Implement createEscrowAccount() function to create and fund escrow accounts - Add calculateStartingBalance() helper function - Calculate required starting balance: getMinimumReserve(3) + depositAmount - Handle InsufficientBalanceError from master account - Return EscrowAccount with accountId, transactionHash, signers, thresholds - Add comprehensive unit tests for starting balance calculation - Export calculateStartingBalance from main SDK entry point Closes amina69#71
- Add findEscrowByAdoptionId() helper function to query Horizon for existing escrow accounts - Implement 60-second caching for Horizon queries to avoid repeat API calls - Add idempotency check to createEscrowAccount() before creating new escrow - Return existing escrow account if found with same adoptionId memo - Comprehensive unit tests for both existing and non-existing account scenarios - Cache behavior tests to ensure 60-second TTL works correctly Closes amina69#74
- Add Keypair.random() call to generate fresh escrow keypair - Return publicKey and secretKey as KeypairResult - Add security comment about secretKey usage - Add unit tests for valid G.../S... pair generation - Ensure unique keypair generation Closes amina69#70
Feature/escrow create account
- Remove unused KeypairResult import from tests - Fix hasOwnProperty lint error in keypair tests - Allow console.log in ESLint config for CLI files - All lint and type-check now passing
[SDK · Account management] Implement generateKeypair()
Enforce plain decimal format with up to 7 fractional digits and reject scientific notation, with unit tests covering issue-required amount cases. Made-with: Cursor
Made-with: Cursor
…d transaction flow
…tion status via Horizon
…tody-funds Feature/lock custody funds
…svalidamount-validator
…crow-manager-class
…funds-types Feature/issue 33 lock funds types
…crow-manager-class
…fecycle-implement-escrow-manager-class fix: implement EscrowManager with dependency-injected lifecycle deleg…
…gner-modification-v2 fix: implement handleDispute signer modification
[SDK · Account management] Implement isValidSecretKey() validator
…svalidamount-validator
- Resolved merge conflicts by accepting develop branch implementation - Updated with latest changes from upstream develop
- Resolved merge conflicts by accepting develop branch implementation - Updated with latest changes from upstream develop
…cy-check feat: implement createEscrowAccount() with idempotency check
…svalidamount-validator
…ment-implement-isvalidamount-validator [amina69#51] [SDK · Account management] Implement isValidAmount() validator
feat: implement createEscrowAccount() function
…uilders-build-set-options-op-helper fix: implement buildSetOptionsOp helper for transaction builders
|
@samad13 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
amina69
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #148
done clean up and fix every bugs