Skip to content

[SDK · Account management] Implement AccountManager class#63

Open
OluRemiFour wants to merge 4 commits intoamina69:developfrom
OluRemiFour:implement-account-manager
Open

[SDK · Account management] Implement AccountManager class#63
OluRemiFour wants to merge 4 commits intoamina69:developfrom
OluRemiFour:implement-account-manager

Conversation

@OluRemiFour
Copy link
Copy Markdown

Close: #60

Implemented AccountManager with injected horizonClient, masterSecretKey, and network, plus the full public surface: generate(), create(), verify(), configureMultisig(), merge(), and fundTestnet(). The class is now a thin delegator in [src/accounts/index.ts], with the actual account operations in [src/accounts/operations.ts].

The operations use only the injected class-level Horizon client, add JSDoc on every public class method, and consistently wrap Stellar SDK/Horizon failures into typed SDK errors like ValidationError, AccountNotFoundError, HorizonSubmitError, and FriendbotError. I also exported the new API from [src/index.ts] and tightened type exports in [src/types/index.ts].

Verification passed with:

npm run type-check
npm test -- --runInBand
Delegation coverage was added in [tests/unit/accounts/account-manager.test.ts].

@OluRemiFour
Copy link
Copy Markdown
Author

Done, Close: #63

@amina69
Copy link
Copy Markdown
Owner

amina69 commented Mar 26, 2026

@OluRemiFour you are suppose to push to develop not main. and was also suppose to branch of develop, it in the contributing.md...please read it before starting the project

@OluRemiFour OluRemiFour changed the base branch from main to develop March 26, 2026 12:13
@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 26, 2026

@OluRemiFour Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@OluRemiFour
Copy link
Copy Markdown
Author

@OluRemiFour you are suppose to push to develop not main. and was also suppose to branch of develop, it in the contributing.md...please read it before starting the project

Fixed, Close: #63

@amina69
Copy link
Copy Markdown
Owner

amina69 commented Mar 26, 2026

@OluRemiFour test is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SDK · Account management] Implement AccountManager class

3 participants