[SDK · Account management] Implement AccountManager class#63
Open
OluRemiFour wants to merge 4 commits intoamina69:developfrom
Open
[SDK · Account management] Implement AccountManager class#63OluRemiFour wants to merge 4 commits intoamina69:developfrom
OluRemiFour wants to merge 4 commits intoamina69:developfrom
Conversation
Author
|
Done, Close: #63 |
Owner
|
@OluRemiFour you are suppose to push to develop not main. and was also suppose to branch of develop, it in the contributing.md...please read it before starting the project |
|
@OluRemiFour Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
Fixed, Close: #63 |
Owner
|
@OluRemiFour test is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #60
Implemented AccountManager with injected horizonClient, masterSecretKey, and network, plus the full public surface: generate(), create(), verify(), configureMultisig(), merge(), and fundTestnet(). The class is now a thin delegator in [src/accounts/index.ts], with the actual account operations in [src/accounts/operations.ts].
The operations use only the injected class-level Horizon client, add JSDoc on every public class method, and consistently wrap Stellar SDK/Horizon failures into typed SDK errors like ValidationError, AccountNotFoundError, HorizonSubmitError, and FriendbotError. I also exported the new API from [src/index.ts] and tightened type exports in [src/types/index.ts].
Verification passed with:
npm run type-check
npm test -- --runInBand
Delegation coverage was added in [tests/unit/accounts/account-manager.test.ts].