Open
Conversation
Author
|
Done, Close: #66 |
|
@innovativedesign-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, Close: #66 |
Owner
|
@innovativedesign-lab check failed |
Owner
|
@innovativedesign-lab little conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #56
Implemented verifyAccount() and wired it into the SDK export surface.
The new logic in [src/accounts/index.ts] validates the publicKey, calls Horizon’s /accounts/:id endpoint, maps a found account into AccountInfo, returns exists: false on 404, and throws HorizonSubmitError for fetch/network and other non-OK responses. I also exported it from [src/index.ts].
Coverage for the requested cases is in [tests/unit/accounts/index.test.ts] existing account, non-existent account, invalid key, plus a network-error case. I installed dependencies, which updated package-lock.json.
Verification passed:
npm test -- --runInBand tests/unit/accounts/index.test.ts
npm run type-check
npm run lint -- src/accounts/index.ts tests/unit/accounts/index.test.ts src/index.ts