feat: implement createEscrowAccount() function#90
Merged
amina69 merged 4 commits intoamina69:developfrom Mar 30, 2026
Merged
Conversation
- Add Keypair.random() call to generate fresh escrow keypair - Return publicKey and secretKey as KeypairResult - Add security comment about secretKey usage - Add unit tests for valid G.../S... pair generation - Ensure unique keypair generation Closes amina69#70
|
@gracekenn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@gracekenn read the contributing .md before starting please |
- Resolved merge conflicts by accepting develop branch implementation - Updated with latest changes from upstream develop
amina69
approved these changes
Mar 30, 2026
Author
|
Hi, @amina69 please close as completed. |
Author
|
I'm not getting my point because its not closed as completed |
Author
hi.. I'll create a ticket and report this.. I'm communicating with you and you dont want to respond
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70