feat: implement createEscrowAccount() with 2-of-3 multisig setup#91
Open
gracekenn wants to merge 4 commits intoamina69:developfrom
Open
feat: implement createEscrowAccount() with 2-of-3 multisig setup#91gracekenn wants to merge 4 commits intoamina69:developfrom
gracekenn wants to merge 4 commits intoamina69:developfrom
Conversation
gracekenn
commented
Mar 27, 2026
gracekenn
commented
- Add AccountManager class with configureMultisig functionality
- Implement createEscrowAccount() to create escrow with 2-of-3 multisig
- Configure adopter, owner, and platform as signers with weight 1 each
- Set thresholds: low=0, medium=2, high=2 for 2-of-3 multisig
- Remove master key as signer after account creation
- Add comprehensive verification of signer configuration
- Include unit tests for all functionality
- Closes [SDK · Escrow lifecycle] Implement createEscrowAccount() — multisig setup step #72
- Add AccountManager class with configureMultisig functionality - Implement createEscrowAccount() to create escrow with 2-of-3 multisig - Configure adopter, owner, and platform as signers with weight 1 each - Set thresholds: low=0, medium=2, high=2 for 2-of-3 multisig - Remove master key as signer after account creation - Add comprehensive verification of signer configuration - Include unit tests for all functionality - Closes amina69#72
|
@gracekenn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Resolved merge conflicts by accepting develop branch implementation - Kept AccountManager export for our multisig functionality - Develop branch has more complete escrow implementation with Stellar SDK integration - Our AccountManager can be used alongside the new architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.