fix: touch translator pan/pinch mode-lock, DPI-scaled thresholds, main-menu first-tap#15
Open
mvanhorn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Touch translator pan/pinch mode-lock, DPI-scaled thresholds, main-menu first-tap.
Why this matters
The reporter ported this repo's iOS touch->mouse gesture translator to Android and surfaced three feel-level defects that apply equally to iPhone/iPad. (1) Two-finger pan and pinch run simultaneously from the same PAN phase, so panning fingers emit spurious zoom steps and pinching fingers drift the camera. (2) The tap dead-zone is a fixed 8 px, which is ~0.7 mm on dense panels, so fingertip jitter turns taps into accidental drag-boxes (rally-point misfires). (3) The main menu only reveals after the mouse moves 20 px; on touch there is no idle motion, so the first tap's hover triggers the reveal transition and the deferred click lands mid-transition while buttons are still hidden and is silen
Testing
Changes are scoped to the files named in the fix; added or updated tests where the project has a suite, and matched existing conventions.
Fixes #11