Rate limiting #236
Open
Rate limiting #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkisor
commented
Jan 10, 2024
| @@ -28,6 +28,7 @@ | |||
| class TreeStats < Sinatra::Base | |||
| configure :production do | |||
| use Sentry::Rack::CaptureExceptions | |||
| use RateLimiter, limit: 100, seconds: 60 | |||
There was a problem hiding this comment.
This means 100 requests are allowed every 60 seconds per IP address.
These numbers aren't based on any real data.
We could configure by environment variable.
jkisor
commented
Jan 10, 2024
| private | ||
|
|
||
| def build_key(ip) | ||
| "rate_limiter:#{ip}:#{Time.now.to_i / @seconds}" |
There was a problem hiding this comment.
You may decide on a different key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To config, edit
use RateLimiter, limit: 100, seconds: 60inapp.rb. The default is 100 requests per 60 seconds per IP address.To test, Run in production mode.
RACK_ENV=production rackup config.ruHere's a log when using
use RateLimiter, limit: 2, seconds: 15