Skip to content

[WIP] Support MOI.VectorNonlinearOracle - #3

Merged
amontoison merged 9 commits into
amontoison:am/oraclefrom
andrewrosemberg:ar/oracle
Dec 16, 2025
Merged

[WIP] Support MOI.VectorNonlinearOracle#3
amontoison merged 9 commits into
amontoison:am/oraclefrom
andrewrosemberg:ar/oracle

Conversation

@andrewrosemberg

@andrewrosemberg andrewrosemberg commented Dec 12, 2025

Copy link
Copy Markdown

Comment thread src/utils.jl
Comment on lines +87 to +97
"""
NonLinearStructure

Structure containing Jacobian and Hessian structures of nonlinear constraints:
- jac_rows: row indices of the Jacobian in Coordinate format (COO) format
- jac_cols: column indices of the Jacobian in COO format
- nnzj: number of non-zero entries in the Jacobian
- hess_rows: row indices of the Hessian in COO format
- hess_cols: column indices of the Hessian in COO format
- nnzh: number of non-zero entries in the Hessian
"""

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to help me remember easily

@amontoison

Copy link
Copy Markdown
Owner

@andrewrosemberg Should we store the constraints for the oracle before or after the other nonlinear constraints?
If we add the new "oracle constraints" after, we may reduce the "diff code" and maybe do less errors with the indices but the question is opened.

@andrewrosemberg

Copy link
Copy Markdown
Author

@andrewrosemberg Should we store the constraints for the oracle before or after the other nonlinear constraints? If we add the new "oracle constraints" after, we may reduce the "diff code" and maybe do less errors with the indices but the question is opened.

Yeah that sounds like a good idea. I will fix the already modified code and continue updating with this standard

@amontoison
amontoison merged commit 5327256 into amontoison:am/oracle Dec 16, 2025
2 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants