Skip to content

Fix close event for IE #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix close event for IE #653

wants to merge 1 commit into from

Conversation

frankfoerster
Copy link

The event cycle is not completely finished before the close method is called which causes IE to not close the datepicker.

@DanielRuf
Copy link
Contributor

Was there some transition / animation running? Will merge it but it should be revisited later.

@DanielRuf
Copy link
Contributor

Hm, can you rerun the Travis build?

@DanielRuf DanielRuf self-requested a review March 31, 2018 21:23
DanielRuf
DanielRuf suggested changes Mar 31, 2018
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR to get the changes from the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DanielRuf DanielRuf DanielRuf requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankfoerster @DanielRuf