Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JESD204B support on VCK190 #1233

Merged
merged 2 commits into from
Aug 27, 2024
Merged

JESD204B support on VCK190 #1233

merged 2 commits into from
Aug 27, 2024

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Dec 5, 2023 •
edited
Loading

PR Description

This PR adds the jesd204b support for the AD9081 project on VCK190.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bluncan bluncan requested a review from FilipG24 December 5, 2023 14:36
@bluncan bluncan force-pushed the versal_jesd204b branch 2 times, most recently from 28e937d to c395c85 Compare December 5, 2023 14:45
IuliaCMoldovan
IuliaCMoldovan requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the code changes to add support for JESD204B on Versal, I think the documentation for AD9081/AD9082 should be updated accordingly, to give details on what was updated here.

AndrDragomir
AndrDragomir previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@AndrDragomir AndrDragomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I tested this support with adrv9026 and it worked.

acostina
acostina previously approved these changes Jul 3, 2024
View reviewed changes
@bluncan bluncan dismissed stale reviews from acostina and AndrDragomir via 250b200 July 17, 2024 07:36
@bluncan bluncan requested a review from LBFFilho as a code owner July 17, 2024 07:36
@bluncan bluncan force-pushed the versal_jesd204b branch 2 times, most recently from 744c770 to 17b247c Compare July 25, 2024 18:08
@bluncan
Copy link
Contributor Author

bluncan commented Jul 25, 2024

v2: Rebased to main and working

@bluncan bluncan force-pushed the versal_jesd204b branch 3 times, most recently from 04a44b3 to 0799417 Compare July 29, 2024 05:42
IuliaCMoldovan
IuliaCMoldovan previously approved these changes Aug 1, 2024
View reviewed changes
bluncan added 2 commits August 1, 2024 15:08
@bluncan
ad9081: vck190: Added support for JESD204B
1256773 
ad9209: vck190: Changed serial connections and added reset signals
Signed-off-by: Bogdan Luncan <[email protected]>
@bluncan
versal_transceiver: Fixed asymmetric modes
f70d27f 
Signed-off-by: Bogdan Luncan <[email protected]>
@bluncan bluncan merged commit dd59ae6 into main Aug 27, 2024
0 of 3 checks passed
@bluncan bluncan deleted the versal_jesd204b branch August 27, 2024 05:54
bia1708 pushed a commit that referenced this pull request Sep 3, 2024
@bluncan @bia1708
JESD204B support on VCK190 (#1233)
3920207 
* ad9081: vck190: Added support for JESD204B
ad9209: vck190: Changed serial connections and added reset signals
Signed-off-by: Bogdan Luncan <[email protected]>

* versal_transceiver: Fixed asymmetric modes

Signed-off-by: Bogdan Luncan <[email protected]>

---------

Signed-off-by: Bogdan Luncan <[email protected]>
sarpadi pushed a commit that referenced this pull request Sep 20, 2024
@bluncan @sarpadi
JESD204B support on VCK190 (#1233)
9904a57 
* ad9081: vck190: Added support for JESD204B
ad9209: vck190: Changed serial connections and added reset signals
Signed-off-by: Bogdan Luncan <[email protected]>

* versal_transceiver: Fixed asymmetric modes

Signed-off-by: Bogdan Luncan <[email protected]>

---------

Signed-off-by: Bogdan Luncan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipG24 FilipG24 FilipG24 approved these changes

@AndrDragomir AndrDragomir AndrDragomir approved these changes

@acostina acostina acostina left review comments

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan left review comments

@podgori podgori Awaiting requested review from podgori

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bluncan @acostina @FilipG24 @IuliaCMoldovan @AndrDragomir