Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library/spi_engine: fix segmented transfers with echo_sclk #1532

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

library/spi_engine: fix segmented transfers with echo_sclk #1532

wants to merge 3 commits into from
+32 −42

Conversation

LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Nov 28, 2024 •
edited
Loading

PR Description

Currently, segmented transfers (where two transfer instructions of different lenghts are used without deasserting CS to assemble a single SPI transfer) are broken when using echo_sclk. This PR fixes this issue.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@LBFFilho LBFFilho requested a review from sarpadi November 28, 2024 18:45
@LBFFilho
SPI Engine: fix segmented transfers with echo_sclk
6399547 
Signed-off-by: Laez Barbosa <[email protected]>
@LBFFilho
SPI Engine: improve timing
8d2c41a 
pre-compute the last bit counter value

Signed-off-by: Laez Barbosa <[email protected]>
@LBFFilho LBFFilho force-pushed the echo_sclk_segmented_fix branch from c75b87e to 8d2c41a Compare December 6, 2024 14:50
@sarpadi sarpadi marked this pull request as ready for review December 10, 2024 08:30
@sarpadi
Copy link
Contributor

sarpadi commented Dec 10, 2024

RetriggerCI

@LBFFilho LBFFilho changed the title SPI Engine: fix segmented transfers with echo_sclk library/spi_engine: fix segmented transfers with echo_sclk Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

@podgori podgori Awaiting requested review from podgori podgori is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@ladace ladace Awaiting requested review from ladace ladace is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LBFFilho @sarpadi