Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: intel: adi_jesd204: adi_jesd204_hw: Fix sip_tile string #1540

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Dec 10, 2024

PR Description

In quartus 24.2 the 'get_part_info -sip_tile' command also returns the number of tiles which made some of the ifs that were matching on the type of tile fail.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@gastmaier
Copy link
Contributor

The CI .../job/main/job/builds/job/main_PR_1540/job/projects/job/ad9081_fmca_ebz.s10soc/ looks good

gastmaier
gastmaier previously approved these changes Dec 11, 2024
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the 24.2 adds values to returned string, the solutions is backwards compatible:

tcl>  set sip_tile_info "Z-Tile"
Z-Tile
tcl> regexp {[A-Z]\-Tile} $sip_tile_info sip_tile
1
tcl> puts $sip_tile
Z-Tile

tcl>  set sip_tile_info "Z-Tile New Info"
Z-Tile New Info
tcl> regexp {[A-Z]\-Tile} $sip_tile_info sip_tile
1
tcl> puts $sip_tile
Z-Tile

Note to consider:
Intel help shows :

~$ quartus_sh --tcl_eval puts [get_part_info -sip_tile]
        -sip_tile: Option to get SiP tile (such as L-tile, H-tile, E-tile)

with the T of tile undercase. Maybe it is safer to regex both T and t? regexp {[A-Z]\-[Tt]ile}

In quartus 24.2 the 'get_part_info -sip_tile' command also returns
the number of tiles which made some of the ifs that were matching
on the type of tile fail.

Signed-off-by: Bogdan Luncan <[email protected]>
@bluncan
Copy link
Contributor Author

bluncan commented Dec 11, 2024

Since the 24.2 adds values to returned string, the solutions is backwards compatible:

tcl>  set sip_tile_info "Z-Tile"
Z-Tile
tcl> regexp {[A-Z]\-Tile} $sip_tile_info sip_tile
1
tcl> puts $sip_tile
Z-Tile

tcl>  set sip_tile_info "Z-Tile New Info"
Z-Tile New Info
tcl> regexp {[A-Z]\-Tile} $sip_tile_info sip_tile
1
tcl> puts $sip_tile
Z-Tile

Note to consider: Intel help shows :

~$ quartus_sh --tcl_eval puts [get_part_info -sip_tile]
        -sip_tile: Option to get SiP tile (such as L-tile, H-tile, E-tile)

with the T of tile undercase. Maybe it is safer to regex both T and t? regexp {[A-Z]\-[Tt]ile}

Good idea, I rewrote it it use -nocase and we only match the actual tile now since we don't really care about the '-Tile' part.

@bluncan bluncan requested a review from gastmaier December 11, 2024 15:15
@bluncan bluncan merged commit 85cec8f into main Dec 12, 2024
3 of 4 checks passed
@bluncan bluncan deleted the quartus_24_2_s10soc_fix branch December 12, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants