-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(BLE): ME18 PHY + PAL UART + clean.cordio #1080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-gillespie
approved these changes
Jul 11, 2024
EricB-ADI
changed the title
fix(BLE): ME18 PHY and clean.cordio
fix(BLE): ME18 PHY + PAL UART + clean.cordio
Jul 12, 2024
/clang-format-run |
Not sure if disabling the terminal echo will help with our test automation. I can't tell if the tests now are failing because of the UART in general, the echo, or BLE disconnects. diff --git a/Libraries/Cordio/wsf/sources/util/terminal.c b/Libraries/Cordio/wsf/sources/util/terminal.c
index 7d97f548ff..85a8e10ade 100644
--- a/Libraries/Cordio/wsf/sources/util/terminal.c
+++ b/Libraries/Cordio/wsf/sources/util/terminal.c
@@ -101,7 +101,7 @@ void TerminalInit(wsfHandlerId_t handlerId)
terminalCb.handlerId = handlerId;
terminalCb.pFirstCommand = NULL;
terminalCb.isExecuting = FALSE;
- terminalCb.doEcho = TRUE;
+ terminalCb.doEcho = FALSE;
terminalCb.bufOffset = 0;
TerminalRegisterCommand(&terminalCommandHelp); |
/clang-format-run |
/clang-format-run |
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Jul 25, 2024
EricB-ADI
added a commit
that referenced
this pull request
Aug 21, 2024
Co-authored-by: Kevin Gillespie <[email protected]> Co-authored-by: EricB-ADI <[email protected]>
EricB-ADI
pushed a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit b47c56e.
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ME18 PHY
The ME18 PHY was showing some issues in stability. This build is the most up to date and stable PHY we have.
PAL UART
PAL UART
triggers an assertion by default anytime an error occurs. Now if it is in on the console or theHCI UART
, the FIFO is flushed and we continue. Cordio has no mechanism to bubble the error back up, so if an error occurs on HCI, two errors will always occur unless extremely lucky.The first error is the actual error from reported by the hardware. The second error is Cordio not being able to recreate an HCI packet since, the packet is incomplete as the previous partial segment is being added to the new segment.
After this error it starts over and goes back to normal.
The error always seems to be an overflow error. The best solution for this is to enable HW flow control.
clean.cordio
Fixed clean.cordio recipe in libCordio.mk. The
MAXIM_PATH
is not properly being passed down, so if you do not have theMAXIM_PATH
set as an environment variable,clean.cordio
does not work. CMSIS_PATH is set so I just used a relative path from that.