fix(PeriphDrivers): Fix for special GPIO ports #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32655
perkinsmg
changed the title
perkinsmg
changed the title
ttmut
requested changes
Nov 24, 2025
perkinsmg
force-pushed
the
fix/gpio-port-condition-bug
branch
from
c11d697 to
4a99107
Compare
perkinsmg
force-pushed
the
fix/gpio-port-condition-bug
branch
from
4a99107 to
d3d5474
Compare
ttmut
requested changes
Nov 25, 2025
Don't call MXC_GPIO_SetDriveStrength for the special GPIO ports that are set up via MCR registers. MXC_GPIO_SetDriveStrength calls MXC_GPIO_RevA_SetDriveStrength directly and this only configures pins that are handled via the usual GCR registers. Signed-off-by: Michael Perkins <[email protected]>
perkinsmg
force-pushed
the
fix/gpio-port-condition-bug
branch
from
d3d5474 to
dacedbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't call MXC_GPIO_SetDriveStrength for the special GPIO ports that are set up via MCR registers. MXC_GPIO_SetDriveStrength calls MXC_GPIO_RevA_SetDriveStrength directly and this only configures pins that are handled via the usual GCR registers.
Checklist Before Requesting Review