-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver: adxl38x - bare-metal driver for parts ADXL380 and ADXL382 #2210
base: main
Are you sure you want to change the base?
Conversation
45e6773
to
a02151a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the PR.
- Please sign the CLA
- add separate commit for the application example
- add a commit for documentation of the driver
- add a commit for the documentation of the project
a02151a
to
e527153
Compare
There are some compilation warnings which need to be fix:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some remarks from my side. most of them are duplicated, but please check the files again to make changes are applies too all instances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some remarks on the second commit
projects/eval-adxl38x/src/examples/selftest_example/st_example_main.c
Outdated
Show resolved
Hide resolved
projects/eval-adxl38x/src/examples/selftest_example/st_example_main.c
Outdated
Show resolved
Hide resolved
projects/eval-adxl38x/src/examples/selftest_example/st_example_main.c
Outdated
Show resolved
Hide resolved
projects/eval-adxl38x/src/examples/selftest_example/st_example_main.c
Outdated
Show resolved
Hide resolved
1e9e058
to
6748188
Compare
drivers/accel/adxl38x/adxl38x.c
Outdated
size + 1); | ||
} else { | ||
dev->comm_buff[0] = base_address; | ||
ret = no_os_i2c_write(dev->com_desc.i2c_desc, dev->comm_buff, size + 1, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
6748188
to
2b4c5f8
Compare
Bare-metal driver for parts ADXL380 and ADXL382 Signed-off-by: Balarupini Rajendran <[email protected]>
Signed-off-by: Balarupini Rajendran <[email protected]>
2b4c5f8
to
e980f2c
Compare
Pull Request Description
Bare metal device drivers for ADXL380/382 parts.
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist