Format begin end comment

.circleci/config.yml

@@ -93,7 +93,7 @@ jobs:
             - brew-cache-v1
       - checkout
       - run: bin/ci prepare_system
-      - run: echo 'export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/opt/openssl/lib/pkgconfig"' >> $BASH_ENV
+      - run: echo 'export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/opt/openssl@1.1/lib/pkgconfig"' >> $BASH_ENV
       - run: echo 'export CURRENT_TAG="$CIRCLE_TAG"' >> $BASH_ENV
       - run: bin/ci prepare_build
       - run: bin/ci build
@@ -172,7 +172,7 @@ jobs:
       - run: |
           git clone https://github.com/crystal-lang/distribution-scripts.git ~/distribution-scripts
           cd ~/distribution-scripts
-          git checkout cfe843ff938697174afea976f4499fef806b5286
+          git checkout e1704da2a215264ea8e101eb15d4ec1baae98222
       # persist relevant information for build process
       - run: |
           cd ~/distribution-scripts
@@ -183,7 +183,7 @@ jobs:
           echo "export CRYSTAL_SHA1=$CIRCLE_SHA1" >> build.env
 
           # Which previous version use
-          export PREVIOUS_CRYSTAL_BASE_URL="https://github.com/crystal-lang/crystal/releases/download/0.34.0/crystal-0.34.0-1"
+          export PREVIOUS_CRYSTAL_BASE_URL="https://github.com/crystal-lang/crystal/releases/download/0.35.1/crystal-0.35.1-1"
           echo "export PREVIOUS_CRYSTAL_RELEASE_LINUX64_TARGZ=${PREVIOUS_CRYSTAL_BASE_URL}-linux-x86_64.tar.gz" >> build.env
           echo "export PREVIOUS_CRYSTAL_RELEASE_LINUX32_TARGZ=${PREVIOUS_CRYSTAL_BASE_URL}-linux-i686.tar.gz" >> build.env
           echo "export PREVIOUS_CRYSTAL_RELEASE_DARWIN_TARGZ=${PREVIOUS_CRYSTAL_BASE_URL}-darwin-x86_64.tar.gz" >> build.env
@@ -225,12 +225,17 @@ jobs:
     steps:
       - attach_workspace:
           at: /tmp/workspace
+      - checkout
+      - run: |
+          # We need CRYSTAL_VERSION in prepare_nightly to use src/VERSION so we publish them as x.y.z-dev in apt/rpm
+          #
+          # How to brand it
+          echo "export CRYSTAL_VERSION=$(cat src/VERSION)" >> /tmp/workspace/distribution-scripts/build.env
+          #
+          # TODO: We might want to do that on docker images also to support updates on multiple development versions the same date.
       - run: |
           cd /tmp/workspace/distribution-scripts
 
-          # How to brand it
-          export VERSION=nightly-$(date '+%Y%m%d')
-          echo "export CRYSTAL_VERSION=$VERSION" >> build.env
           echo "export DOCKER_TAG=nightly" >> build.env
 
           # Build from working directory (needed for omnibus and when version does not match branch/tag)
@@ -358,6 +363,24 @@ jobs:
           paths:
             - build
 
+  dist_bintray_nightly:
+    machine: true
+    steps:
+      - attach_workspace:
+          at: /tmp/workspace
+      - run:
+          no_output_timeout: 20m
+          command: |
+            cd /tmp/workspace/distribution-scripts
+            source build.env
+            cd bintray
+            ./publish-nightly.sh $CRYSTAL_VERSION $(date '+%Y-%m-%d') \
+                /tmp/workspace/build/crystal-*-linux-x86_64.tar.gz \
+                /tmp/workspace/build/crystal-*-linux-i686.tar.gz
+      - store_artifacts:
+          path: /tmp/workspace/distribution-scripts/bintray/build/unsigned
+          destination: unsigned
+
   dist_docker:
     machine: true
     steps:
@@ -434,6 +457,7 @@ jobs:
       - attach_workspace:
           at: /tmp/workspace
       - run:
+          # $SNAPCRAFT_TOKEN is generated using `snapcraft export-login --snaps crystal --channels edge,edge/* -`
           command: |
             cd /tmp/workspace/distribution-scripts
             source build.env
@@ -521,13 +545,14 @@ workflows:
             branches:
               ignore:
                 - /release\/.+/
+                - /package\/.+/
                 - /.*\bci\b.*/
       - test_linux32_std:
           filters: *unless_maintenance
       - test_alpine:
           filters: *unless_maintenance
-      - test_darwin:
-          filters: *unless_maintenance
+      # - test_darwin:
+      #     filters: *unless_maintenance
       - test_preview_mt:
           filters: *unless_maintenance
       - check_format:
@@ -552,8 +577,8 @@ workflows:
           filters: *per_tag
       - test_alpine:
           filters: *per_tag
-      - test_darwin:
-          filters: *per_tag
+      # - test_darwin:
+      #     filters: *per_tag
       - test_preview_mt:
           filters: *per_tag
       - check_format:
@@ -627,7 +652,7 @@ workflows:
       - test_linux
       - test_linux32_std
       - test_alpine
-      - test_darwin
+      # - test_darwin
       - test_preview_mt
       - check_format
       - prepare_common
@@ -643,6 +668,10 @@ workflows:
       - dist_darwin:
           requires:
             - prepare_nightly
+      - dist_bintray_nightly:
+          requires:
+            - dist_linux
+            - dist_linux32
       - dist_docker:
           requires:
             - dist_linux
@@ -687,8 +716,8 @@ workflows:
           filters: *maintenance
       - test_alpine:
           filters: *maintenance
-      - test_darwin:
-          filters: *maintenance
+      # - test_darwin:
+      #     filters: *maintenance
       - test_preview_mt:
           filters: *maintenance
       - check_format:
@@ -751,3 +780,33 @@ workflows:
             - dist_darwin
             - dist_snap
             - dist_docs
+
+  package_build:
+    jobs:
+      - prepare_common:
+          filters: &package
+            branches:
+              only:
+                - /package\/.+/
+      - prepare_maintenance:
+          filters: *package
+          requires:
+            - prepare_common
+      - dist_linux:
+          filters: *package
+          requires:
+            - prepare_maintenance
+      - dist_linux32:
+          filters: *package
+          requires:
+            - prepare_maintenance
+      - dist_darwin:
+          filters: *package
+          requires:
+            - prepare_maintenance
+      - dist_artifacts:
+          filters: *package
+          requires:
+            - dist_linux
+            - dist_linux32
+            - dist_darwin

.github/workflows/aarch64.yml

@@ -0,0 +1,107 @@
+name: AArch64 CI
+
+on: [push, pull_request]
+
+jobs:
+  musl-build:
+    runs-on: [linux, ARM64]
+    if: github.repository == 'crystal-lang/crystal'
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+      - name: Build Crystal
+        uses: docker://jhass/crystal:0.35.0-alpine-build
+        with:
+          args: make crystal
+      - name: Upload Crystal executable
+        uses: actions/upload-artifact@v1
+        with:
+          name: crystal-aarch64-musl
+          path: .build/crystal
+  musl-test-stdlib:
+    needs: musl-build
+    runs-on: [linux, ARM64]
+    if: github.repository == 'crystal-lang/crystal'
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+      - name: Download Crystal executable
+        uses: actions/download-artifact@v1
+        with:
+          name: crystal-aarch64-musl
+          path: .build/
+      - name: Mark downloaded compiler as executable
+        run: chmod +x .build/crystal
+      - name: Run stdlib specs
+        uses: docker://jhass/crystal:0.35.0-alpine-build
+        with:
+          args: make std_spec
+  musl-test-compiler:
+    needs: musl-build
+    runs-on: [linux, ARM64]
+    if: github.repository == 'crystal-lang/crystal'
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+      - name: Download Crystal executable
+        uses: actions/download-artifact@v1
+        with:
+          name: crystal-aarch64-musl
+          path: .build/
+      - name: Mark downloaded compiler as executable
+        run: chmod +x .build/crystal
+      - name: Run compiler specs
+        uses: docker://jhass/crystal:0.35.0-alpine-build
+        with:
+          args: make compiler_spec
+  gnu-build:
+    runs-on: [linux, ARM64]
+    if: github.repository == 'crystal-lang/crystal'
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+      - name: Build Crystal
+        uses: docker://jhass/crystal:0.35.0-build
+        with:
+          args: make crystal
+      - name: Upload Crystal executable
+        uses: actions/upload-artifact@v1
+        with:
+          name: crystal-aarch64-gnu
+          path: .build/crystal
+  gnu-test-stdlib:
+    needs: gnu-build
+    runs-on: [linux, ARM64]
+    if: github.repository == 'crystal-lang/crystal'
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+      - name: Download Crystal executable
+        uses: actions/download-artifact@v1
+        with:
+          name: crystal-aarch64-gnu
+          path: .build/
+      - name: Mark downloaded compiler as executable
+        run: chmod +x .build/crystal
+      - name: Run stdlib specs
+        uses: docker://jhass/crystal:0.35.0-build
+        with:
+          args: make std_spec
+  gnu-test-compiler:
+    needs: gnu-build
+    runs-on: [linux, ARM64]
+    if: github.repository == 'crystal-lang/crystal'
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+      - name: Download Crystal executable
+        uses: actions/download-artifact@v1
+        with:
+          name: crystal-aarch64-gnu
+          path: .build/
+      - name: Mark downloaded compiler as executable
+        run: chmod +x .build/crystal
+      - name: Run compiler specs
+        uses: docker://jhass/crystal:0.35.0-build
+        with:
+          args: make compiler_spec

.github/workflows/linux.yml

@@ -0,0 +1,101 @@
+name: Linux CI
+
+on: [push, pull_request]
+
+env:
+  TRAVIS_OS_NAME: linux
+  SPEC_SPLIT_DOTS: 160
+
+jobs:
+  test_linux:
+    env:
+      ARCH: x86_64
+      ARCH_CMD: linux64
+    runs-on: ubuntu-latest
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+
+      - name: Prepare System
+        run: bin/ci prepare_system
+
+      - name: Prepare Build
+        run: bin/ci prepare_build
+
+      - name: Test
+        run: bin/ci build
+
+  test_linux_32:
+    env:
+      ARCH: i386
+      ARCH_CMD: linux32
+    runs-on: ubuntu-latest
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+
+      - name: Prepare System
+        run: bin/ci prepare_system
+
+      - name: Prepare Build
+        run: bin/ci prepare_build
+
+      - name: Test
+        run: bin/ci with_build_env 'make std_spec threads=1'
+
+  test_alpine:
+    env:
+      ARCH: x86_64-musl
+      ARCH_CMD: linux64
+    runs-on: ubuntu-latest
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+
+      - name: Prepare System
+        run: bin/ci prepare_system
+
+      - name: Prepare Build
+        run: bin/ci prepare_build
+
+      - name: Test
+        run: bin/ci build
+
+  test_preview_mt:
+    env:
+      ARCH: x86_64
+      ARCH_CMD: linux64
+    runs-on: ubuntu-latest
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+
+      - name: Prepare System
+        run: bin/ci prepare_system
+
+      - name: Prepare Build
+        run: bin/ci prepare_build
+
+      - name: Make Crystal
+        run: bin/ci with_build_env 'make crystal'
+
+      - name: Test
+        run: bin/ci with_build_env 'CRYSTAL_WORKERS=4 make std_spec threads=1 FLAGS="-D preview_mt"'
+
+  check_format:
+    env:
+      ARCH: x86_64
+      ARCH_CMD: linux64
+    runs-on: ubuntu-latest
+    steps:
+      - name: Download Crystal source
+        uses: actions/checkout@v2
+
+      - name: Prepare System
+        run: bin/ci prepare_system
+
+      - name: Prepare Build
+        run: bin/ci prepare_build
+
+      - name: Check Format
+        run: bin/ci format