fix: hash vuln db only once on load (#2054)

Signed-off-by: Lucas Rodriguez <[email protected]>

grype/db/curator.go

@@ -122,7 +122,7 @@ func (c *Curator) Status() Status {
 		SchemaVersion: metadata.Version,
 		Location:      c.dbDir,
 		Checksum:      metadata.Checksum,
-		Err:           c.Validate(),
+		Err:           nil,
 	}
 }
 

grype/load_vulnerability_db_bench_test.go

@@ -0,0 +1,26 @@
+package grype
+
+import (
+	"path/filepath"
+	"testing"
+
+	"github.com/anchore/grype/grype/db"
+	"github.com/anchore/grype/internal"
+)
+
+// this benchmark was added to measure the performance
+// of LoadVulnerabilityDB, specifically in regards to hash validation.
+// https://github.com/anchore/grype/issues/1502
+func BenchmarkLoadVulnerabilityDB(b *testing.B) {
+	cfg := db.Config{
+		DBRootDir:           filepath.Join(".tmp", "grype-db"),
+		ListingURL:          internal.DBUpdateURL,
+		ValidateByHashOnGet: true,
+	}
+	for range b.N {
+		_, _, _, err := LoadVulnerabilityDB(cfg, true)
+		if err != nil {
+			b.Fatal(err)
+		}
+	}
+}