Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v6 DB metadata store #2146

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Add v6 DB metadata store #2146

merged 2 commits into from
Oct 4, 2024

Conversation

wagoodman
Copy link
Contributor

Partial implementation for #2128 and #2132 in terms of the DBMetadata object

Adds:

  • the DBMetadata table for v6
  • the store reader and writer implementation

This was referenced Sep 26, 2024
Open
Open
@wagoodman wagoodman marked this pull request as ready for review September 26, 2024 20:22
@wagoodman wagoodman requested a review from a team September 26, 2024 20:22
@wagoodman wagoodman self-assigned this Sep 26, 2024
@wagoodman wagoodman force-pushed the add-v6-db-metadata branch 2 times, most recently from 4bc8249 to d3b3966 Compare September 27, 2024 20:37
Base automatically changed from v6-foundation to main September 30, 2024 13:30
@wagoodman
add db metadata store
692c36b 
Signed-off-by: Alex Goodman <[email protected]>
willmurphyscode
willmurphyscode reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@willmurphyscode willmurphyscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd like to do a sync review on this, since it's foundational, to make sure I understand how it.

grype/db/internal/gormadapter/open.go Outdated Show resolved Hide resolved
@wagoodman wagoodman merged commit cabf8bc into main Oct 4, 2024
10 checks passed
@wagoodman wagoodman deleted the add-v6-db-metadata branch October 4, 2024 20:12
@wagoodman wagoodman added enhancement New feature or request changelog-ignore Don't include this issue in the release changelog labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmurphyscode willmurphyscode willmurphyscode approved these changes

Assignees

@wagoodman wagoodman

Labels
changelog-ignore Don't include this issue in the release changelog enhancement New feature or request
Projects
OSS
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @willmurphyscode