fix: remove second call to finalize as the task handles it #2516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2509
This PR removes the double call to
relationships.Finalize
.To validate the fix run the following using the latest release of syft:
Then using this gist you can evaluate the output relationships from above and find the dupes:
https://gist.github.com/spiffcs/72b641f04ac79d160ce079bcd3816382
Run the same command as above using the tip of this branch:
And then rerun the gist again on the output:
https://gist.github.com/spiffcs/72b641f04ac79d160ce079bcd3816382
There should no longer be any duplicates shown in the output
An integration test has also been added to project against this regression going forward where duplicate edges are not tolerated for the given
image-pkg-coverage
. The test was checked for failure against the change and shown to fail if the secondFinalize
call was not removed