Internalize majority of cmd package #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
migrate-integration-tests
branch
from
212e13b
to
d49c379
Compare
spiffcs
approved these changes
Jan 23, 2024
...ernal/test/integration/test-fixtures/npm-lock/node_modules/collapse-white-space/package.json
Outdated
Show resolved
Hide resolved
wagoodman
commented
Jan 24, 2024
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
commented
Jan 24, 2024
cmd/syft/internal/test/integration/test-fixtures/npm-lock/node_modules/insert-css/example.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Goodman <[email protected]>
…ests Signed-off-by: Alex Goodman <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* internalize majority of cmd package and migrate integration tests Signed-off-by: Alex Goodman <[email protected]> * add internal api encoder Signed-off-by: Alex Goodman <[email protected]> * create internal representation of all formats Signed-off-by: Alex Goodman <[email protected]> * export capability to get default encoders Signed-off-by: Alex Goodman <[email protected]> * restore test fixtures Signed-off-by: Alex Goodman <[email protected]> --------- Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the
cmd/syft/cli/commandsandcmd/syft/cli/optionstocmd/syft/internal. In the process of doing so it became necessary to:cmd/syft/internal...as well since there are specificoptions.*objects that help test against real CLI defaults (which is important in integration testing).internal/encodersto act as an internal API for the full set of encoders that we can express, so that the CLI tests understand what formats should be under test.