Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JVM cataloger #3217

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add JVM cataloger #3217

wants to merge 5 commits into from

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Sep 10, 2024 •
edited
Loading

Implements a JVM cataloger, capable of detecting OpenJDK and Oracle JDK installations based off of release files:

IMPLEMENTOR="Oracle Corporation"
JAVA_RUNTIME_VERSION="22.0.2+9-70"
JAVA_VERSION="22.0.2"
JAVA_VERSION_DATE="2024-07-16"
LIBC="gnu"
MODULES="java.base java.compiler java.datatransfer ..."
OS_ARCH="aarch64"
OS_NAME="Linux"
SOURCE=".:git:5b97d5323482 open:git:8153097cea20"

No java/jre/jdk binary signatures have been removed, since it's possible that folks may still be installing a JDK and purging the release file, but in cases when both are found the binary signature package is dropped (in favor of the JVM binary package).

Closes #2422
Closes #3188
Closes #1426

@github-actions github-actions bot added the json-schema Changes the json schema label Sep 10, 2024
@wagoodman wagoodman added the ecosystem:java relating to the java ecosystem label Sep 10, 2024
@wagoodman wagoodman requested a review from a team September 10, 2024 13:12
@wagoodman wagoodman marked this pull request as draft September 10, 2024 13:22
@wagoodman wagoodman marked this pull request as ready for review September 11, 2024 15:33
@wagoodman wagoodman force-pushed the openjdk-cataloger branch 2 times, most recently from ecb230d to 0670351 Compare September 11, 2024 16:37
@wagoodman
add jvm cataloger
1542f45 
Signed-off-by: Alex Goodman <[email protected]>
@gdams gdams mentioned this pull request Sep 12, 2024
Open
@wagoodman
simplify version selection
ac8f7e7 
Signed-off-by: Alex Goodman <[email protected]>
@wagoodman
Copy link
Contributor Author

Heads up: this is blocked from being merged until an appropriate grype matcher is implemented (working on that now)

@wagoodman wagoodman added the blocked Progress is being stopped by something label Sep 13, 2024
@wagoodman wagoodman mentioned this pull request Sep 13, 2024
Open
kzantow
kzantow approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- it's been an ask for a while!

internal/relationship/exclude_binaries_by_file_ownership_overlap.go Show resolved Hide resolved
internal/relationship/exclude_binaries_by_file_ownership_overlap.go Show resolved Hide resolved
syft/internal/fileresolver/chroot_context.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

@westonsteimel westonsteimel Awaiting requested review from westonsteimel

Assignees
No one assigned
Labels
blocked Progress is being stopped by something ecosystem:java relating to the java ecosystem json-schema Changes the json schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catalog JDKs more completely OpenJDK CPEs Show richer information for JVM installations
2 participants
@wagoodman @kzantow