fix(spdx): populate package locations from SPDX relationships #4153
+610
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves anchore#4028 Extract file locations from SPDX File-Package relationships during SPDX document decoding to ensure packages have proper location information instead of null values. - Add populatePackageLocationsFromRelationships() function - Support evident-by comments (Syft SBOMs) and CONTAINS relationships - Integrate into ToSyftModel() pipeline - Add comprehensive test coverage - Maintain backward compatibility This fixes null locations in Grype vulnerability reports for SPDX SBOMs. Signed-off-by: Nils Lamot <[email protected]>
Improve SPDX relationship processing to exclude license files, documentation, and man pages from package location evidence. Refactor populatePackageLocationsFromRelationships into smaller functions and add comprehensive test coverage for file filtering logic. Signed-off-by: Nils Lamot <[email protected]>
|
Hi @kzantow Based on the description in the issue, I've implemented a fix. However, I did notice that if we purely use the CONTAINS relationship as evidence, this results in the SBOM identifying things like the LICENSE files in my SPDX SBOMs as the location of a package. I added logic to cope with this, but this logic is rather naive. Is this an issue in my SBOM? Or is this a general issue and is the way I fixed it acceptable? Kind regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract file locations from SPDX File-Package relationships during SPDX document decoding to ensure packages have proper location information instead of null values.
This fixes null locations in Grype vulnerability reports for SPDX SBOMs.
Type of change
Checklist: