feat: 🎸 prevent mapping with void functions (WIP?) #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential implementation of the changes described in #76. Disallowing
void
functions from being passed to.map
turned out to be more tricky than I initially thought.This works, but with a major caveat: it also blocks functions that return
undefined
. I couldn't find a way to permitunknown
without permittingvoid
, (asvoid
is assignable tounknown
). They'd have to cast theirunknown
s asNotVoid
.So I'm not completely happy with this change; I'm putting it up as something between a WiP and a PoC.