Added support for multiple destinations#1
Open
Crixu wants to merge 5 commits into
Open
Conversation
Added check if origin = destination
andrea-sdl
reviewed
Feb 21, 2024
Comment on lines
+45
to
+47
| // console.log( | ||
| // `Airfare price from ${origin} to ${destination} on ${DEPARTURE_DATE} - ${RETURN_DATE}: $${price}` | ||
| // ); |
Owner
There was a problem hiding this comment.
@Crixu curious why you commented this, was it too much noisy?
Author
There was a problem hiding this comment.
Oh yeah I commented it out as I saved the output as CSV but I guess most people would like this kind of process reporting
andrea-sdl
reviewed
Feb 21, 2024
| adults: 1, | ||
| currencyCode: "USD", | ||
| max: 3, | ||
| max: 1, // Only fetch the cheapest flight |
Owner
There was a problem hiding this comment.
@Crixu did you test it already? I initially set 3 because with 1 I would, sometimes, get no results on some origin-destination combinations, where with 3 I would always get some.
Author
There was a problem hiding this comment.
Oh good to know. I mainly thought about reducing the needed time for the checks if it would only include one of them.
Switched to check 3 flights
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option to specify a destinations.txt file and write the output to a CSV file