Build v3 desktop foundation - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cd apps/apm-desktop && npm testcd apps/apm-desktop && npm run open:macos:preview -- --dry-runcd apps/apm-desktop && npm run open:macos:preview:dmg -- --dry-runcd apps/apm-desktop && npm run verify:v3:localcd apps/apm-desktop && npm run release:macos:status -- --repo andreanjos/apm --tag v0.1.1 --markdown --untracked-files allgit diff --check && git diff --cached --checkRelease Notes
Local preview app/DMG artifacts are verified and runnable, but public release remains blocked until:
.github/workflows/desktop-release.ymlis merged to the default branchmacos-desktop-releaseGitHub Environment secrets are configuredv0.1.1is moved/recreated for the merged release commitpublish=falseDesktop Release run passesrelease:macos:workflow-accept