Skip to content

teste passando + fix code smells #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafaelnsantos wants to merge 3 commits into
base: master
Choose a base branch
from
Open

teste passando + fix code smells #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ef47e7
fix code smells
rafaelnsantos Aug 22, 2018
9c9ae07
teste passando
rafaelnsantos Aug 22, 2018
6dd122f
teste csv passando
rafaelnsantos Aug 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/br/utfpr/tdd/ex1/Aluno.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ void setNotaProjeto(double nota) {
double getNF() {
if(notaRAA < 0)
return (notaProjeto + getNAP()) / 2.0;

return (notaProjeto + getNAP() + notaRAA) / 3.0;

double NF = (notaProjeto + getNAP() + notaRAA) / 3.0 ;
return NF > 6 ? 6 : NF;
}

void setNotaRAA(double nota) {
Expand Down
25 changes: 12 additions & 13 deletions src/main/java/br/utfpr/tdd/ex1/EscritorCSV.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package br.utfpr.tdd.ex1;

import java.io.BufferedWriter;
import java.io.IOException;
import java.math.RoundingMode;
import java.nio.file.Files;
import java.nio.file.Paths;
Expand All @@ -9,28 +10,27 @@
import java.util.Locale;
import java.util.logging.Level;
import java.util.logging.Logger;

import org.apache.commons.csv.CSVFormat;
import org.apache.commons.csv.CSVPrinter;

/**
*
* @author andreendo
*/
class EscritorCSV {
CSVPrinter csvPrinter;
private final static Logger LOGGER = Logger.getLogger(EscritorCSV.class.getName());
private static final Logger LOGGER = Logger.getLogger(EscritorCSV.class.getName());

void escrever(String ra, String nome, double notaFinal, String situacao) {
try {
Locale locale = new Locale("en", "UK");
Locale locale = new Locale("en", "UK");
DecimalFormat df = (DecimalFormat)
NumberFormat.getNumberInstance(locale);
NumberFormat.getNumberInstance(locale);
df.applyPattern(".#");
df.setRoundingMode(RoundingMode.DOWN);
csvPrinter.printRecord(ra, nome, df.format(notaFinal), situacao);
csvPrinter.flush();
}
catch(Exception e) {
csvPrinter.flush();
} catch (Exception e) {
LOGGER.log(Level.SEVERE, e.getMessage(), e);
}
}
Expand All @@ -40,12 +40,11 @@ void setArquivoSaida(String filePath) {
BufferedWriter writer = Files.newBufferedWriter(Paths.get(filePath));

csvPrinter = new CSVPrinter(writer, CSVFormat.DEFAULT
.withHeader("RA", "Nome", "NF", "Situacao"));
csvPrinter.flush();
}
catch(Exception e) {
.withHeader("RA", "Nome", "NF", "Situacao"));
csvPrinter.flush();
} catch (Exception e) {
LOGGER.log(Level.SEVERE, e.getMessage(), e);
}
}

}