Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting and shouldBeEmpty parameter #4

Closed
wants to merge 1 commit into from
Closed

Add sorting and shouldBeEmpty parameter #4

wants to merge 1 commit into from

Conversation

tim-the-junior
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@helen-the-senior
Copy link
Collaborator

Tim, even if the Quality Gate is green, I still expect you to check the comments before asking for review.

Could you please fix:

  • the two code smells (Clean as You Code)? To convert the codebase to the coding style we've voted in the team.
  • you got lucky on code coverage, you didn't add any test for the sorting algorithm - please add a test

@tim-the-junior tim-the-junior deleted the tim/add-more-stuff branch August 23, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helen-the-senior helen-the-senior Awaiting requested review from helen-the-senior

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tim-the-junior @helen-the-senior