Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting and shouldBeEmpty parameter #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tim-the-junior
Copy link
Collaborator

No description provided.

@helen-the-senior helen-the-senior requested review from helen-the-senior and removed request for helen-the-senior August 23, 2023 20:11
helen-the-senior

This comment was marked as duplicate.

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Repository owner deleted a comment from sonarcloud bot May 8, 2024
@helen-the-senior
Copy link
Collaborator

helen-the-senior commented May 8, 2024

Tim, please add the necessary code coverage to pass the Quality Gate!

And please do the extra mile and check the SonarCloud results, even if those issues are tolerated by the tool. Especially the "StartsWith" rule - you might learn something new.

Did you install SonarLint like I told you last time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants