adding a budget function #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @anthony-meza, sorry I just saw this now! Thanks for submitting the PR. The budget addition looks great and I'd love to get it merged (I didn't mess with including it at the Summer School since I didn't really understand the ECCO budgets, but I think you do!). However, your recent commits that modify the tracer module got added here as well since this is from your main branch. Would you mind submitting a new PR from a branch that doesn't contain the tracer modifications? Unless there is something broken in the tracer implementation, in which case I'd love to know that as well 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a function that reads in the budget tool output