Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major multi-purpose update. #38

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

BoatrightTBC
Copy link

  1. Fix all mysql calls to mysqli calls
  2. fix all non-initialized variables (mostly in punchclock) causing warnings.
  3. Replace broken phpweather (noaa discontinued the service) with saratoga-weather, which just looks nicer anyway.
  4. Fix issues with path to the logo file, which is in timeclock/images but when running code from admin or reports or punchclock it was looking in admin/images etc... oops. Fixed.

Yes, I know this is a huge pull request, but the mysql touched almost every file. This now runs in php 5.5 with NO ERRORS ANYWHERE

php weather used a now-dead noaa service.  The replacement saratoga-weather uses a service which is guaranteed to work for a long time.  Plus it looks better.  -- added files and added variables to config.inc.php
lots of non-initialized variable causing warnings -- fixed.  All mysql calls fixed.
// 12 Hour with or without leading zeros with upper or lower case AM or PM 
      // First digit of hours in 12 hour format can not be > 1.              
      // First digit of minutes can not be > 5 any time.                         
 // 24 Hour with or without leading zeros with upper or lower case AM or PM 
      //    First digit of hours in 24 hour format can not be > 2.           
      //    First digit of minutes can not be > 5 any time.                      
      //    No am/pm in 24 hour format.  No need for case indifferent /i.
@rjonesbsink
Copy link

these following errors show up when performing certain tasks
https://pilotweb.nas.faa.gov/qryhtml/icao/ the link is dead
trying to delete a time clock entry for a user: Warning: preg_match(): Unknown modifier ',' in C:\xampp\htdocs\timeclock\admin\timedelete.php on line 288
Notice: Undefined variable: tzo in C:\xampp\htdocs\timeclock\admin\timeadd.php on line 546
Notice: Undefined variable: tzo in C:\xampp\htdocs\timeclock\admin\timeadd.php on line 693
hours workded report shows a different time than the time that was entered
can not find metar for the city of cleveland, OH as the above link is dead
Notice: Undefined index: metar in C:\xampp\htdocs\timeclock\admin\sysedit.php on line 1282

duelafn and others added 5 commits March 9, 2017 11:04
Create some helper functions to prepare/execute and return result objects
so that code can move away from stripslashes/addslashes insanity without
too much pain. Converted a handful of scripts so far.
Allow barcode clock-in. This required a few changes:

  - Add a punchnext field to punchlist table which specifies which punch
    status should be moved to when we scan our barcode.

  - Add a barcode UNIQUE field to the employees table.

  - Modify user search to accept barcodes: additionally, I removed the
    restriction of searching on only a single search term. Terms are now
    AND-ed together.

  - Create new configuration options "$barcode_clockin" and
    "$manual_clockin" which toggle the display of each login form on the
    main clock-in screen.

Due to the creation of the "punchnext" property, the In/Out punch field no
longer needs to be filled in even for normal punches (provided the
"punchnext" fields have been populated by an administrator).

The barcode entry is configured to not auto-complete and is automatically
focused on page load, so any barcode scanner or card reader which emulates
keyboard input should work fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants