Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*PHP 7 Upgrades* #47

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

*PHP 7 Upgrades* #47

wants to merge 23 commits into from

Conversation

Kayoti
Copy link

@Kayoti Kayoti commented May 31, 2020

*major refactor of DB functions ->mysqli
*major refactor of project functions to adapt & work with mysqli functions

  • major upgrade to php code removed deprecated functions introduced compatible functions with PHP7
  • refactored code that was ambiguous simplified some code
    *fixed all warning and notices that caused some issues and bugs on the project
  • changes may not be optimal but are enough to get the project working with php7
  • audit log page does not display data for me on my tests (this could be an issue from before) could be fixed not a major issue

- New Folders img
- theme css files added
- theme js files added
-admin login redesign
-reports admin login redesign
-* commit message change -> config.ini changes enable admin login in reports page.
fake db creditentials
-added sidenav.php file
-New top navigation bar is now on the right side
-New icon set
-header file has new meta data
-Added side nav bar
-Clean Top Page header
-New leftmain.php display.php UI changes
-Bootstrap Form input fields & tables Added
-topmain.php UI edits (does not work with serverside scripts yet)
- few edits and tweaks on other files to fix html includes and divs
-footer hasnew  js libraries included
-UI changes only affect timeclock.php
Allow login logout for top drop down menu
fix daily report css adjustments added
-reverted all interface changes to default to start working on new interface
-added library for bootstrap 4 to manage interface
*major refactor of functions that are deprecated and implementing php functions that work with PHP7
* resolved multiple issues with variable assignments that caused warning and notices across the project
* refactored some code lines to mitigate conflicts with new functions that are compatible with PHP7
* refactored code that seemed ambiguous and introduced simpler code
* fixed some bugs here and there
* the project seems smooth and functional with exception to audit log page which does not seem to display any data perhaps this was an issue that was there from before
* Please note most of the changes introduced may not seem optimal but they are stable enough to produce a working project for PHP7
*major refactor of DB functions ->mysqli
*major refactor of project functions to adapt & work with mysqli functions
* major upgrade to php code removed deprecated functions introduced compatible functions with PHP7
* refactored code that was ambiguous simplified some code
*fixed all warning and notices that caused some issues and bugs on the project
* changes may not be optimal but are enough to get the project working with php7
* audit log page does not display data (this could be an issue from before)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants