-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*PHP 7 Upgrades* #47
Open
Kayoti
wants to merge
23
commits into
andrew867:master
Choose a base branch
from
Kayoti:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
*PHP 7 Upgrades* #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New Folders img - theme css files added - theme js files added -admin login redesign -reports admin login redesign
-* commit message change -> config.ini changes enable admin login in reports page. fake db creditentials
-added sidenav.php file -New top navigation bar is now on the right side -New icon set -header file has new meta data
-Added side nav bar -Clean Top Page header
-New leftmain.php display.php UI changes -Bootstrap Form input fields & tables Added
-topmain.php UI edits (does not work with serverside scripts yet) - few edits and tweaks on other files to fix html includes and divs -footer hasnew js libraries included -UI changes only affect timeclock.php
fix daily report css adjustments added
-reverted all interface changes to default to start working on new interface -added library for bootstrap 4 to manage interface
*major refactor of functions that are deprecated and implementing php functions that work with PHP7 * resolved multiple issues with variable assignments that caused warning and notices across the project * refactored some code lines to mitigate conflicts with new functions that are compatible with PHP7 * refactored code that seemed ambiguous and introduced simpler code * fixed some bugs here and there * the project seems smooth and functional with exception to audit log page which does not seem to display any data perhaps this was an issue that was there from before * Please note most of the changes introduced may not seem optimal but they are stable enough to produce a working project for PHP7
*major refactor of DB functions ->mysqli *major refactor of project functions to adapt & work with mysqli functions * major upgrade to php code removed deprecated functions introduced compatible functions with PHP7 * refactored code that was ambiguous simplified some code *fixed all warning and notices that caused some issues and bugs on the project * changes may not be optimal but are enough to get the project working with php7 * audit log page does not display data (this could be an issue from before)
lokilust
approved these changes
May 7, 2021
lokilust
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*major refactor of DB functions ->mysqli
*major refactor of project functions to adapt & work with mysqli functions
*fixed all warning and notices that caused some issues and bugs on the project