New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compatibility with numba v0.51.2 #4

Open

ashrielbrian wants to merge 2 commits into andrewdcampbell:master from ashrielbrian:numba-fix

ashrielbrian commented Oct 22, 2020 •

edited

Loading

This fixes the deprecation warnings from numba (#3 ) due to object mode fallback when nopython mode fails.

Redundant @jit decorators were removed.

These were decorators that did not speed up the code due to numba object mode fallback.

Added explicit nopython decorators: @njit

that way, if there is a compile failure, an error will be explicitly thrown.

Refactored functions to be numba-compatible.

np.int -> np.int_
np.bool -> np.bool_
np.average -> np.mean
refactored the loop get_minimum_seam into a separate function and added the @njit decorator.

These refactorings did not have any noticeable effect on the performance of the algorithm during benchmarking.

ashrielbrian added 2 commits

October 22, 2020 17:23


          Fixed numba v0.51.2 compatibility

87c24f2


          Fixed numba v0.51.2 compatibility

1b5e5d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet