Skip to content

Conversation

andrewhickman
Copy link
Owner

@andrewhickman andrewhickman commented Aug 1, 2025

Implements a better way to detect if a oneof is synthetic for #174

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 52.87356% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.77%. Comparing base (6d9e8cb) to head (988beb8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
prost-reflect/src/dynamic/message.rs 0.00% 12 Missing ⚠️
prost-reflect/src/descriptor/build/resolve.rs 25.00% 6 Missing ⚠️
prost-reflect/src/descriptor/build/options.rs 0.00% 4 Missing ⚠️
prost-reflect/src/descriptor/error.rs 75.00% 4 Missing ⚠️
prost-reflect/src/dynamic/text_format/format.rs 75.00% 4 Missing ⚠️
prost-reflect/src/dynamic/serde/de/kind.rs 50.00% 2 Missing ⚠️
prost-reflect/src/dynamic/serde/de/wkt.rs 33.33% 2 Missing ⚠️
prost-reflect/src/dynamic/text_format/parse/mod.rs 33.33% 2 Missing ⚠️
prost-reflect/src/descriptor/build/mod.rs 66.66% 1 Missing ⚠️
prost-reflect/src/dynamic/fields.rs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   79.69%   79.77%   +0.07%     
==========================================
  Files          31       31              
  Lines        5250     5255       +5     
==========================================
+ Hits         4184     4192       +8     
+ Misses       1066     1063       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrewhickman andrewhickman changed the title Add OneofDescriptor::is_synthetic feat: Add OneofDescriptor::is_synthetic Aug 1, 2025
@andrewhickman andrewhickman merged commit e5fabe2 into main Aug 1, 2025
6 of 7 checks passed
This was referenced Aug 1, 2025
@github-actions github-actions bot mentioned this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant