Add localized desktop settings and menus - #592
Open
nx111 wants to merge 1 commit into
Open
Conversation
The desktop shim and native CEF menus currently contain hard-coded English labels, while Jellyfin Web and the rest of the application are localized. This makes the settings and application menus inconsistent for non-English users. Add a small CEF-side translation resource, inject the selected desktop locale into the web shim, and use localized labels for settings sections, options, menus, and about information. Keep English fallbacks for missing keys and preserve the existing native/Web locale behavior. User-facing brand strings follow the upstream Jellium Desktop rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop shim and native CEF menus currently contain hard-coded English labels, while Jellyfin Web and the rest of the application are localized. This makes the settings and application menus inconsistent for non-English users.
Add a small CEF-side translation resource, inject the selected desktop locale into the web shim, and use localized labels for settings sections, options, menus, and about information. Keep English fallbacks for missing keys and preserve the existing native/Web locale behavior.