fix(cef): map console severity using CEF ABI values - #654
Open
selmant wants to merge 1 commit into
Open
Conversation
Align FFI and app log-severity constants with cef_log_severity_t so CEF console filtering matches how browser events already interpret levels. Document the ABI value table at both call sites. Co-authored-by: Cursor <cursoragent@cursor.com>
selmant
force-pushed
the
fix/cef-log-severity-abi
branch
from
August 2, 2026 15:18
d8ed83a to
5ded2c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map
jfn_cef_set_log_severityintegers tocef_log_severity_twith an explicit match instead of transmute on historical Chromium levels (-1..2).Align app CEF filter constants with the same ABI values already used by console-message handling in
client/events.rs.Document the ABI table at the FFI and app constant sites:
Test plan
cargo clippy --manifest-path src/Cargo.toml -p jfn-cef -p jfn-rust -- -D warnings