Fix up ObjectIdentifier first subidentifier encoding/decoding#281
Merged
andrivet merged 3 commits intoandrivet:masterfrom Sep 7, 2024
nealian:fix-oid-roots
Merged
Fix up ObjectIdentifier first subidentifier encoding/decoding#281andrivet merged 3 commits intoandrivet:masterfrom nealian:fix-oid-roots
andrivet merged 3 commits intoandrivet:masterfrom
nealian:fix-oid-roots
Conversation
Owner
|
Hi. Thanks for the PR. I will look at it in the next few days. |
|
Owner
|
New release published on GitHub and PyPi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As laid out in #280, the first "subidentifier" (the first two OID subcomponents) has somewhat different encoding rules. I think I touched everything I need and I hope the tests pass... I don't have the right python versions installed to run anything.