Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Commit

Permalink
Mark unfocused single password fields as fillable (#1258)
Browse files Browse the repository at this point in the history
Unfocused single password fields in forms with no other recognized
fields must be marked as fillable or the Autofill service will no
longer be invoked on that form.

This is compatible with the restrictions of single-origin mode as
filling only takes place after the password field has gained focus and
the user has tapped the fill UI.

For an example website where fill UI is not shown without this commit,
open https://amazon.lbb.de and tab the user name field ("Benutzername")
first before focusing the password field.

(cherry picked from commit c15594b)
  • Loading branch information
fmeum authored and msfjarvis committed Mar 20, 2021
1 parent eaa541b commit de1b976
Showing 1 changed file with 20 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,26 @@ internal val autofillStrategy = strategy {
}
}

// Fallback rule for the case of a login form with a password field and other fields that are
// not recognized by any other rule. If one of the other fields is focused and we return no
// response, the system will not invoke the service again if focus later changes to the password
// field. Hence, we must mark it as fillable now.
// This rule can apply in single origin mode since even though the password field may not be
// focused at the time the rule runs, the fill suggestion will only show if it ever receives
// focus.
rule(applyInSingleOriginMode = true) {
currentPassword {
takeSingle { hasAutocompleteHintCurrentPassword }
}
}

// See above.
rule(applyInSingleOriginMode = true) {
genericPassword {
takeSingle { true }
}
}

// Match any focused password field with optional username field on manual request.
rule(applyInSingleOriginMode = true, applyOnManualRequestOnly = true) {
genericPassword {
Expand Down

0 comments on commit de1b976

Please sign in to comment.