Small fixes in MyModelViewModelTest #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR and thanks for the catch! Why |
|
Good question. If |
kworth
force-pushed
the
small-test-fixes
branch
from
8b38367 to
b4579df
Compare
kworth
force-pushed
the
small-test-fixes
branch
from
b4579df to
0101d9a
Compare
|
Actually, it looks like the tests fail using |
|
@JoseAlcerreca any reason not to merge this in? |
|
Sorry, looking into it. |
JoseAlcerreca
approved these changes
Nov 17, 2023
|
Thanks, approved! @kworth this needs to be replicated in the multimodule branch as well. Do you want to do it? |
|
Ah, good point. I think I should be able to make time for that. I haven't looked at that branch at all yet. Hopefully it's not too divergent and will be a quick cherry-pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As things are currently, the
MyModelViewModelTestgives the impression of being a useful starting point, but ultimately leaves a lot to be desired. It has 2 tests with different names that have the same logic, and as soon as you go to update the second test to do what it says it does, theFakeMyModelRepositoryimplementation doesn't act as one would reasonably expect (you can calladdMyModelall you want, but still the only thing that was ever emitted was an empty list).This PR aims to make the class more correct and helpful. Please see individual commits which should be self-explanatory.