Skip to content

[Jetchat] fix: white padding in profile screen in dark mode #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
magdalena-trivina wants to merge 7 commits into from
Closed

[Jetchat] fix: white padding in profile screen in dark mode #1505

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
679fa20
fix: white padding in profile screen in dark mode
magdalena-trivina Nov 12, 2024
6dddd4c
Merge branch 'main' into jetchat/fix_white-padding-in-profile-screen-…
mlykotom Nov 18, 2024
8dfb930
Merge branch 'main' into jetchat/fix_white-padding-in-profile-screen-…
mlykotom Nov 19, 2024
bdfb7de
fix: apply formatting
magdalena-trivina Nov 20, 2024
b5ca7db
Merge branch 'main' into jetchat/fix_white-padding-in-profile-screen-…
simona-anomis Dec 10, 2024
1b3adee
Merge branch 'main' into jetchat/fix_white-padding-in-profile-screen-…
simona-anomis Dec 12, 2024
cae6487
Merge branch 'main' into jetchat/fix_white-padding-in-profile-screen-…
simona-anomis Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Jetchat/app/src/main/java/com/example/compose/jetchat/profile/Profile.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.layout.navigationBarsPadding
import androidx.compose.foundation.layout.offset
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.systemBarsPadding
import androidx.compose.foundation.layout.widthIn
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.shape.CircleShape
Expand Down Expand Up @@ -89,13 +88,13 @@ fun ProfileScreen(
modifier = Modifier
.fillMaxSize()
.nestedScroll(nestedScrollInteropConnection)
.systemBarsPadding()
) {
Surface {
Column(
modifier = Modifier
.fillMaxSize()
.verticalScroll(scrollState),
.verticalScroll(scrollState)
.padding(16.dp),
Copy link
Collaborator

@riggaroo riggaroo Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should continue to use systemBarsPadding() and not a hardcoded value.

) {
ProfileHeader(
scrollState,
Expand Down
Loading