feat: Add three-pane scene recipe #172
Conversation
The `ThreePaneSceneStrategy` displays three panes side-by-side on large screens (width > 1200dp) when the top three back stack entries support it. On medium screens (width > 600dp), it falls back to a `TwoPaneScene`.
romanofranz
requested review from
claraf3,
dturner,
ianhanniballake and
jbw0033
as code owners
Summary of ChangesHello @romanofranz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new 'three-pane' layout recipe to the application, enhancing its adaptive UI capabilities. It provides a robust strategy for displaying multiple navigation entries concurrently based on screen real estate, ensuring an optimized user experience across various device sizes. The implementation includes a fallback mechanism to a two-pane layout for intermediate screen widths, improving flexibility and responsiveness. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new three-pane scene recipe, which is a great addition for large-screen layouts. The implementation is mostly solid, but I've found a critical issue in the ThreePaneSceneStrategy logic that prevents the two-pane fallback from working correctly when the back stack grows. I've also included a few medium-severity suggestions to improve code correctness and documentation formatting. Please take a look at the detailed comments.
app/src/main/java/com/example/nav3recipes/scenes/threepane/ThreePaneScene.kt
Show resolved
Hide resolved
app/src/main/java/com/example/nav3recipes/scenes/threepane/ThreePaneActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/nav3recipes/scenes/threepane/ThreePaneScene.kt
Outdated
Show resolved
Hide resolved
The `ThreePaneSceneStrategy` displays three panes side-by-side on large screens (width > 1200dp) when the top three back stack entries support it. On medium screens (width > 600dp), it falls back to a `TwoPaneScene`.
# Conflicts: # app/src/main/java/com/example/nav3recipes/scenes/threepane/ThreePaneActivity.kt # app/src/main/java/com/example/nav3recipes/scenes/threepane/ThreePaneScene.kt
|
What benefit does this recipe provide over the |
To cover a wider range of devices. Material 3 guidelines suggest up to 3 panes, depending on the window size. Would it be better to update the TwoPaneScene to something like MultiPaneScene instead of creating a new recipe? |
2 participants
The
ThreePaneSceneStrategydisplays three panes side-by-side on large screens (width > 1200dp) when the top three back stack entries support it. On medium screens (width > 600dp), it falls back to aTwoPaneScene.