Remove all ndk-build samples. #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanAlbert
force-pushed
the
cleanup-ndkbuild
branch
from
b3f8e49 to
39a16cc
Compare
DanAlbert
changed the title
jfgoog
approved these changes
May 7, 2024
|
Okay, none of these are actually interesting. The most they manage to do is show how to do the gradle side of this, but the |
None of these show anything interesting. At first glance I thought a few might be worth preserving, but the few interesting things they do are actually superfluous. I'm removing all of them for now and will add a new sample soon specifically to show how to use ndk-build in a substantial enough way to be useful.
DanAlbert
force-pushed
the
cleanup-ndkbuild
branch
from
39a16cc to
51571d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these show anything interesting. At first glance I thought a few might be worth preserving, but the few interesting things they do are actually superfluous. I'm removing all of them for now and will add a new sample soon specifically to show how to use ndk-build in a substantial enough way to be useful.