Add top level samples project. #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanAlbert
commented
May 7, 2024
DanAlbert
force-pushed
the
combine-samples-project
branch
from
fbe5dad to
e0d4712
Compare
jfgoog
approved these changes
May 7, 2024
DanAlbert
force-pushed
the
combine-samples-project
branch
from
e0d4712 to
e5fe92b
Compare
This is step one of android#1010. It's not really finished until I've removed all the stuff left behind (which I'm leaving for another PR because it's just a big mess of deletes that'd make this PR harder to read). It's may be good to also remove the mostly unnecessary middle directories from most of these. Doing that will break a bunch of existing URLs, but if the goal is to be a project that's actually sensible to copy, we need to rearrange to do that. Maybe that's better left for a broader rearranging that's probably overdue anyway, or maybe we should just leave it as-is to keep the URLs alive.
Now that there's a single top level gradle project, we don't need any of this. The new thing is actually more thorough, because it'll build all build types of each sample instead of just debug, which is quite important for things like the sanitizer sample. android#1010
I haven't removed all the child packaging files yet because this can't be fully driven from this end. There's a service that reads these that needs its index updated to read this instead of all the children first. I'll be back to clean those up once that's been done. android#1010
DanAlbert
force-pushed
the
combine-samples-project
branch
from
e5fe92b to
686fbae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step one of #1010. It's not really finished until I've removed all the stuff left behind (which I'm leaving for another PR because it's just a big mess of deletes that'd make this PR harder to read).
It's may be good to also remove the mostly unnecessary middle directories from most of these. Doing that will break a bunch of existing URLs, but if the goal is to be a project that's actually sensible to copy, we need to rearrange to do that. Maybe that's better left for a broader rearranging that's probably overdue anyway, or maybe we should just leave it as-is to keep the URLs alive.