-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitizer: Set useLegacyPackaging for asan #970
Sanitizer: Set useLegacyPackaging for asan #970
Conversation
959797b
to
3ced853
Compare
3ced853
to
876ed5c
Compare
@DanAlbert @enh-google PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this one i think i do understand, and it does match what i believe to be true. but you might still want to wait for danalbert next week if you want more than a "seems legit?" from someone who doesn't really know what they're talking about :-) )
55f6d50
to
b355695
Compare
I added explanatory comments but otherwise LGTM. |
... but our CI's broken. I'll go look into that. |
GitHub is currently in the middle of rolling out changes to the GHA images that alter how the Android tools are installed: actions/runner-images#8952. That bug says that
I guess |
#975 appears to fix it. Once that merges I'll rebase this PR so the checks can re-run, then it should be good to merge. |
[Why] Property useLegacyPackaging determin whether to use the legacy convention of compressing all .so files in the APK. If null, .so files will be uncompressed and page-aligned when minSdk >= 23. Otherwise, it failed with "INSTALL_FAILED_INVALID_APK: Failed to extract native libraries, res=-2" when minSdk >= 23. And wrap.sh is only available for API level 27 and above. [How] Set useLegacyPackaging to true. Set compileSdk to 27. Reference: https://developer.android.com/ndk/guides/asan
b355695
to
7316939
Compare
[Why]
Property useLegacyPackaging determin whether to use the legacy convention of compressing all .so files in the APK. If null, .so files will be uncompressed and page-aligned when minSdk >= 23. Otherwise, it failed with "INSTALL_FAILED_INVALID_APK: Failed to extract native libraries, res=-2" when minSdk >= 23.
And wrap.sh is only available for API level 27 and above.
[How]
Set useLegacyPackaging to true.
Set compileSdk to 27.
[Reference]
https://developer.android.com/ndk/guides/asan