Uses actual consumed safe drawing inset when composing TopicScreen#1795
Open
anhtuannd wants to merge 1 commit intoandroid:mainfrom
Open
Uses actual consumed safe drawing inset when composing TopicScreen#1795anhtuannd wants to merge 1 commit intoandroid:mainfrom
anhtuannd wants to merge 1 commit intoandroid:mainfrom
Conversation
…reen. Modifier.windowInsetsTopHeight was reset to 0 when navigating from child navigation to top level navigation, caused Spacer not render, and LazyListState updated top position to item 1 instead of 0 (Spacer).
anhtuannd
force-pushed
the
fix_1780_insets
branch
from
5ed7f1c to
baa4bc1
Compare
Contributor
|
Can you also add a screen record of the fix? |
Author
Screen_recording_20250108_234739.mp4 |
Contributor
|
Does your solution still in edge-to-edge on |
Author
|
@Jaehwa-Noh yes
|
Author
|
@alexvanyo How do you think about this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1780
Modifier.windowInsetsTopHeight was reset to 0 when navigating from child navigation to another top level navigation, which caused the Spacer not to render and LazyListState to update the top position to item 1 instead of item 0 (Spacer).