[Graphics] [Sample] UltraHDR Image compression #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL contains sample code for compressing an UltraHDR Images (on API 34 and above) while still maintaining quality How Has This Been Tested? Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta) Checklist I have performed a self-review of my code I have commented my code, particularly in hard-to-understand areas I have made corresponding changes to the documentation Demo The demo shows how to compressing an ultrahdr image and the difference between both. Screenshots
MayuriKhinvasara
added
the
new sample
| ) | ||
|
|
||
| class CompressingUltraHDRImages : Fragment() { | ||
|
|
There was a problem hiding this comment.
Why is there all these random spaces? Can we clean this up just a little to not have them?
There was a problem hiding this comment.
Ack. Removed.
| android:id="@+id/color_mode_controls" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" /> | ||
|
|
There was a problem hiding this comment.
If this is not needed, can you remove it outright?
There was a problem hiding this comment.
Ack. Removed
| @@ -25,7 +27,7 @@ Demonstrates how to implement data access auditing for your app to identify | |||
| - [Displaying UltraHDR](graphics/ultrahdr/src/main/java/com/example/platform/graphics/ultrahdr/display/DisplayingUltraHDR.kt): | |||
| This sample demonstrates displaying an UltraHDR image. | |||
| - [Displaying UltraHDR (3P Libraries)](graphics/ultrahdr/src/main/java/com/example/platform/graphics/ultrahdr/display/DisplayingUltraHDRUsing3PLibrary.kt): | |||
| This sample demonstrates using the various popular image loading libraries to display Ultra HDR images | |||
| This sample demonstrates using the various popular image loading library to | |||
There was a problem hiding this comment.
Why was this changed?
There was a problem hiding this comment.
Ack. was edited by mistake. Restored.
This CL contains sample code for compressing an UltraHDR Images (on API 34 and above) while still maintaining quality How Has This Been Tested? Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta) Checklist I have performed a self-review of my code I have commented my code, particularly in hard-to-understand areas I have made corresponding changes to the documentation Demo The demo shows how to compressing an ultrahdr image and the difference between both. Screenshots
This CL contains sample code for compressing an UltraHDR Images (on API 34 and above) while still maintaining quality How Has This Been Tested? Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta) Checklist I have performed a self-review of my code I have commented my code, particularly in hard-to-understand areas I have made corresponding changes to the documentation Demo The demo shows how to compressing an ultrahdr image and the difference between both. Screenshots
madebymozart
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL contains sample code for compressing an UltraHDR Images (on API 34 and above) while still maintaining quality of the ultrahdr image
How Has This Been Tested?
Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta)
Checklist
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas I have made corresponding changes to the documentation
Demo
The demo shows how to compressing an ultrahdr image and the difference between both.
Screenshots
