Upgrade to media3 1.4.0-rc01 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigmanZero
reviewed
Jul 12, 2024
samples/README.md
Outdated
| @@ -123,7 +123,7 @@ This sample demonstrates converting a series of UltraHDR images into a HDR | |||
| - [UltraHDR x OpenGLES SurfaceView](graphics/ultrahdr/src/main/java/com/example/platform/graphics/ultrahdr/opengl/UltraHDRWithOpenGL.kt): | |||
| This sample demonstrates displaying an UltraHDR image via and OpenGL Pipeline | |||
| - [Video Composition using Media3 Transformer](media/video/src/main/java/com/example/platform/media/video/TransformerVideoComposition.kt): | |||
| This sample demonstrates concatenation of two video assets using Media3 | |||
| This sample demonstrates concatenation of two video assets and an image using | |||
There was a problem hiding this comment.
nit: I think we've lost "Media3" at the end of this sentence?
There was a problem hiding this comment.
whoops! good catch. fixed.
SigmanZero
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed that this fixes #172 cc @droid-girl