-
Notifications
You must be signed in to change notification settings - Fork 321
feat: adds a SharedPreferencesMigration example (preferences) #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @telpirion, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request provides a clear example of how to implement Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR adds an example for SharedPreferences migration. While the intent is good, the implementation has a few issues. The most critical is a missing import that makes the code snippet incomplete. Additionally, the way the snippet is commented out will likely prevent documentation tools from extracting it correctly. I've also included suggestions for a typo and to follow Kotlin's best practices for constants. Addressing these points will ensure the example is correct, complete, and functional.
datastore/src/main/java/com/example/datastore/snippets/preferences/PreferencesDataStore.kt
Outdated
Show resolved
Hide resolved
datastore/src/main/java/com/example/datastore/snippets/preferences/PreferencesDataStore.kt
Outdated
Show resolved
Hide resolved
datastore/src/main/java/com/example/datastore/snippets/preferences/PreferencesDataStore.kt
Outdated
Show resolved
Hide resolved
datastore/src/main/java/com/example/datastore/snippets/preferences/PreferencesDataStore.kt
Outdated
Show resolved
Hide resolved
datastore/src/main/java/com/example/datastore/snippets/preferences/PreferencesDataStore.kt
Outdated
Show resolved
Hide resolved
|
LGTM from snippets repo perspective, may want to get Elif to take a look from DataStore perspective |
This PR adds the
android_datastore_preferences_migrateregion tag. Internal issue 446749253 tracks.Note: I will add a corresponding snippet for proto & JSON preferences as I have time. Thanks!